Upgrade dependencies to clear all security advisories - #10
Merged
Conversation
composer audit reported 25 advisories across 7 packages (guzzle, psr7, league/commonmark, laravel/framework, symfony/routing, symfony/http-foundation, symfony/polyfill-intl-idn) — all transitive via saloon (runtime) and orchestra/testbench (dev). - Targeted composer update of the affected packages with dependencies - laravel/framework 11.x is entirely flagged, so testbench moves to v10 (Laravel 12); this required widening phpunit to ^11.5 || ^12.0 - Pin rector/rector to ~2.5.0: 2.6 removed the strictBooleans parameter that airlst/rector-config dev-master still passes, and 2.4 breaks against the updated phpstan internals - Rector/cs-fixer re-run on src/ with the updated toolchain composer audit --locked is now clean. rector, cs-fixer, phpstan and phpunit all pass locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer auditreported 25 advisories across 7 packages — matching the dependabot alerts on master (6 high). All transitive:guzzlehttp/guzzle+guzzlehttp/psr7via Saloon (runtime), the rest (laravel/framework,league/commonmark,symfony/routing,symfony/http-foundation,symfony/polyfill-intl-idn) via orchestra/testbench (dev-only).After this PR:
composer audit --lockedis clean.Changes
composer update -Wof the affected packages only (rector/phpstan/cs-fixer majors deliberately left untouched where possible).phpunit/phpunitfrom^8 || ^9 || ^10to^11.5 || ^12.0(testbench 10 minimum).rector/rectorpinned to~2.5.0: rector 2.6 removed thestrictBooleansparameter thatairlst/rector-config(dev-master) still passes towithPreparedSets(), and rector 2.4 fatals against the updated phpstan internals. 2.5 works with both. Unpin once airlst/rector-config dropsstrictBooleans(it's deprecated in 2.5 with a warning).src/with the updated toolchain (CI would auto-commit these anyway).Test plan
composer audit --locked— no advisories./vendor/bin/rector— cleancomposer cs-fixer/composer phpstan— cleancomposer test— passingNotes
master; touches some of the samesrc/files as Add sub-events endpoints and regenerate SDK from latest spec #9 (style normalization only) — whichever merges second may need a trivial rebase.🤖 Generated with Claude Code