Add SliceUtf8.toTitleCase()#177
Open
wendigo wants to merge 1 commit into
Open
Conversation
Contributor
Author
Contributor
Author
|
@martint PTAL |
dain
approved these changes
Oct 22, 2025
| return translateCodePoints(utf8, LOWER_CODE_POINTS); | ||
| } | ||
|
|
||
| public static Slice toTitleCase(Slice utf8) |
Member
There was a problem hiding this comment.
Add documentation for how this implementation works and maybe reference which rule set this comes from.
| } | ||
|
|
||
| @Test | ||
| public void testUtf8TitleCaseConversion() |
Member
There was a problem hiding this comment.
Maybe copy some of the text from the toUpper tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is based on the logic of the toLower and toUpper case