Feature/iframe tooltip render#1848
Open
lapidus wants to merge 2 commits intoairbnb:masterfrom
Open
Conversation
Collaborator
|
Hey @lapidus thanks so much for the PR, could you add a screenshot/video of the fixed trigger and positioning? |
Author
|
Thank you @williaster. The trigger is fixed (the mouseover etc. fires as expected and the tooltips shows up) but I didn't get the positioning 100% right in the PR yet. I started adding iframe offset logic to this file: Feel free to add any suggestions to the PR. I'll keep hacking a bit on it and add screenshots 👍 Thanks for the support and a wonderful lib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
Aims to make XYChart tooltips work in iFrame context.