Use mypyc to compile websocket reader - #13559
Conversation
Merging this PR will degrade performance by 30.25%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_read_one_hundred_masked_large_binary_websocket_messages |
60.2 ms | 86.2 ms | -30.25% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mypyc (b7a5c9e) with master (20acdf4)
Footnotes
-
83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13559 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 135 136 +1
Lines 50500 50528 +28
Branches 2652 2652
=======================================
+ Hits 50007 50035 +28
Misses 370 370
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
| # cannot be relied on anywhere. Cost: the reader and its buffers | ||
| # are reclaimed by full GC passes, not refcounting. Never break | ||
| # this cycle manually; remove when the mypyc issue is resolved. | ||
| self._gc_cycle = self |
There was a problem hiding this comment.
This is resulting in GBs of memory use, while removing it is resulting in numerous segfaults. Do not merge until this is fixed.
No description provided.