Auto-close PRs from forks#166
Merged
Merged
Conversation
Deploying aiida-website with
|
| Latest commit: |
ed5106d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7950e0b2.aiida-website.pages.dev |
| Branch Preview URL: | https://ci-close-fork-prs.aiida-website.pages.dev |
khsrali
commented
May 8, 2026
|
|
||
| This repository is maintained by the AiiDA team, and we **discourage external pull requests** as a matter of policy. If you spot a typo, a broken link, outdated content, or have an idea you'd like to see on the site, please [**open an issue**](https://github.com/aiidateam/aiida-website/issues/new) describing the change — we'll handle the implementation. PRs opened from forks are auto-closed with a comment redirecting to Issues. | ||
|
|
||
| The reasoning is twofold: (1) we want a single editorial voice across the site, so changes flow through the team rather than landing piecemeal; and (2) Cloudflare Pages doesn't build preview deployments for fork PRs (a security default — the build environment can hold project secrets), so a fork PR can't be reviewed visually anyway. The Issues path keeps the loop short for everyone. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| The reasoning is twofold: (1) we want a single editorial voice across the site, so changes flow through the team rather than landing piecemeal; and (2) Cloudflare Pages doesn't build preview deployments for fork PRs (a security default — the build environment can hold project secrets), so a fork PR can't be reviewed visually anyway. The Issues path keeps the loop short for everyone. | |
| The reasoning is twofold: (1) we want a single editorial voice across the site, so changes flow through the team rather than landing piecemeal; and (2) Cloudflare Pages doesn't build preview deployments for fork PRs (a security default — the build environment can hold project secrets), so a fork PR can't be reviewed visually anyway (there are workarounds but whatever). The Issues path keeps the loop short for everyone. |
khsrali
commented
May 8, 2026
khsrali
commented
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare Pages doesn't build preview deployments for fork PRs (its build env can hold project secrets, so untrusted code is hard-refused — see CF docs). The Read-the-Docs-style "previews on forks" we used to have only worked because RTD's build had no secrets to protect. Restoring fork previews on CF would mean a two-stage GitHub Actions workflow (build artifact in untrusted context → deploy via CF API token in trusted context), which is real CI surface to maintain for a project that is mostly maintainer-driven. Auto-closing fork PRs with a clear comment is the lower-cost path; we can revisit if community contributions pick up.
Note: opening PRs on this repo from the community is discouraged anyways, we recommend that they open issues, and leave the implementation to us.