Drop React frontend, add PR-feedback workflow#367
Merged
Conversation
khsrali
force-pushed
the
drop-react-frontend
branch
from
dabe99d to
b762e21
Compare
Member
Member
Contributor
Author
|
@edan-bainglass I had a look at the open PRs they are all stale, most of which could be closed. |
GitHub Pages can't emit real 301s. Per-slug stubs (200 + rel=canonical + 0-second meta refresh) are treated by Google as 301-equivalent and pass link equity. noindex deliberately omitted (Google ignores canonical when noindex is present). 404.html catches any unenumerated path via JS. Stubs are pre-generated static files; no CI generator runs in future.
Contributor
Author
|
All commits in the PR have to be squashed before merge |
Contributor
Author
|
@edan-bainglass I'm considering to merge this today, as we have the registry in two places now. |
Member
|
Hi @khsrali. This PR is on my todos for today 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once aiidateam/aiida-website#165 get's merged we'll have to review & merge this PR
--packagefilter totest-installso CI can scope it to PR-touched plugins.plugin-install-testEnvironment configured (with required reviewers) before merge — otherwise the gate is open.