Skip to content

Updating code to check for exit_code#354

Open
ayushjariyal wants to merge 1 commit into
aiidateam:masterfrom
ayushjariyal:issue_352
Open

Updating code to check for exit_code#354
ayushjariyal wants to merge 1 commit into
aiidateam:masterfrom
ayushjariyal:issue_352

Conversation

@ayushjariyal
Copy link
Copy Markdown

issue #352

Instead of passing the entire exec_result object, explicitly check for exit_code.

  • Checks if exit_code is nonzero. if so, it means failure.
  • Ensure that exact_metadata.output is properly passed to handle_error.
  • Convert error output from bytes to string (.decode()) , so it's readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant