Add aiida-sssp-workflow plugin

[unkcpz]

No description provided.

[github-actions]

PR Preview Action v1.4.4
🚀 Deployed preview to https://aiidateam.github.io/aiida-registry/pr-preview/pr-278/
on branch gh-pages at 2023-12-04 14:01 UTC

[ltalirz]

@AhmedBasem20 , the new section in action - very nice

[unkcpz]

Yes, very nice! But since the container uses aiida-core==2.3.1 and my plugin requires aiida-core~=2.4.0 so it tries to install the old version of my plugin. 😂

[ltalirz]

Why is the container not up to date?

[unkcpz]

Two issues. First the aiida-core was not yet released after the new docker stack was built, so the tag that can be used is aiida-core-with-services:edge, the edge is from the main branch. It is better to use latest tag which points to the latest released version. Second, the time needed to run a test install is more than 2 times longer. Since the new docker stack will force us to wait for the services to start.

[unkcpz]

Just did a close look at why it takes so long for the new docker stack, the time to start the container is not too much but with the new version of aiida-core where python 3.8 was deprecated, lots of plugins just can not installed and takes very long to search for correct dependencies. Thus I think it makes sense to accept the test install time is long and I increase the CI timeout to 180 in #280. Let's go and discuss it there (and I'll merge this after #280).

[ltalirz]

with the new version of aiida-core where python 3.8 was deprecated, lots of plugins just can not installed and takes very long to search for correct dependencies.

this is rather worrying to me... does this indicate it would be a good idea to delay this deprecation?

[unkcpz]

does this indicate it would be a good idea to delay this deprecation?

But this is already happened. I thought it won't be a problem but now I realize that if people check the aiida-registry page, it will give a false impression that a plugin cannot be used which does not support py3.9 yet but all fine in python3.8+aiida-core<2.4.0.

I'll compare and see how many plugins encounter such problems and see if we need to worry about it in here or aiida-core or just tell some plugins to migrate to python3.9 (if only 2 or 3 I think this is the easiest way to do so).

[unkcpz]

I realize another catch in terms of docker stack. The install test can actually override the aiida-core, which is why some plugins which not migrated to aiida 2.x still can pass the install test. I think this is not proper. Instead, I'd propose to be more aggressively pinning the aiida-core version as a strict dependency inside the docker image this will prevent plugins that are not compatible with aiida-core version of the container from falsely passing the test.

[ltalirz]

But this is already happened. I thought it won't be a problem but now I realize that if people check the aiida-registry page, it will give a false impression that a plugin cannot be used which does not support py3.9 yet but all fine in python3.8+aiida-core<2.4.0.

I'll compare and see how many plugins encounter such problems and see if we need to worry about it in here or aiida-core or just tell some plugins to migrate to python3.9 (if only 2 or 3 I think this is the easiest way to do so).

I suspect that most plugins will work fine with Python 3.9, but some may have outdated requirements on the python version.
If that is the case, we may want to wait with the upgrade
(actually, so far the only changes in aiida-core I saw that were specific to python 3.9 were related to typing, i.e. not relevant to running it. it may still work on python 3.8 just fine)

I realize another catch in terms of docker stack. The install test can actually override the aiida-core, which is why some plugins which not migrated to aiida 2.x still can pass the install test. I think this is not proper. Instead, I'd propose to be more aggressively pinning the aiida-core version as a strict dependency inside the docker image this will prevent plugins that are not compatible with aiida-core version of the container from falsely passing the test.

That is correct and I agree the aiida-core version should be pinned.

[unkcpz]

Superseded by #299