Upgrade bippy to 0.7.1 - #621
Open
aidenybai wants to merge 3 commits into
Open
Conversation
Co-authored-by: aiden <aiden@million.dev>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Co-authored-by: aiden <aiden@million.dev>
aidenybai
marked this pull request as ready for review
August 17, 2026 05:12
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Co-authored-by: aiden <aiden@million.dev>
aidenybai
added a commit
that referenced
this pull request
Aug 22, 2026
The paired perf bench checked out base `packages/react-grab/src` while leaving the PR's installed dependencies in place, so a dependency bump left base src importing an export the new version dropped. All 15 shards died at fixture startup and the aggregate gate failed a PR whose own code was fine — bippy 0.7.2 removing `getNearestHostFibers` did this to #626 and #621. The swap now takes the base manifests and lockfile too whenever the PR touches one, which both makes the baseline buildable and makes it the comparison a dependency bump actually wants. Manifests the PR adds are dropped first so the base lockfile passes its frozen check, and a base install that still fails falls back to skipping the baseline. The baseline run is also no longer fatal. It is a measurement, not a gate: the base ref has its own CI, and diff-perf-runs.mjs already reports a missing comparison instead of failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
bippyfrom^0.6.1to^0.7.1inpackages/react-graband adapts to the 0.7.x API changes.API adaptations in react-grab
src/core/element-anchors.ts: bippy 0.7.x removedgetNearestHostFibers. Replaced with a localfindNearestHostElementWithTagwalk that preserves the nearest-host-boundary semantics while early-returning the first connected element with the anchor's tag.src/core/context.ts:Fiber._debugOwneris now typedFiber | ServerComponentInfo | null | undefined.getSourceComponentNameaccepts the full_debugOwnertype and narrows with bippy'sisFiber.src/utils/freeze-updates.ts:FiberRoot.currentis now typed non-null, so the defensiveFiberRootLikewidening extendsOmit<FiberRoot, "current">.History
The initial 0.7.0 upgrade surfaced two runtime regressions in bippy itself, traced with instrumented debugging and temporarily fixed via
pnpm patchon this branch:isInstrumentationActive()stayed false forever when bippy loaded after React in stock Vite/Next dev — list keys, component names, owner stacks, and Next server-frame symbolication all silently broke.TypeErroron roots whose current fiber has nomemoizedStateand misclassified them as unmounting.Both fixes landed upstream in bippy 0.7.1, so the final revision bumps to
^0.7.1and removes the local patch — this PR now carries only source adaptations plus the dependency bump.Testing
pnpm typecheck,pnpm lint,pnpm format,pnpm build: all pass.Summary by cubic
Upgrades
bippyto ^0.7.1 inpackages/react-graband adapts to the 0.7 API. Removes the local runtime patch since 0.7.1 includes the react-refresh activation and root tracking fixes.getNearestHostFiberswith a localfindNearestHostElementWithTagwalk. Old: helper returned nearest host fibers. New: walk from the parent fiber and return the first connected element whose tag matches the anchor. Side effect: when multiple same‑tag siblings exist under the same composite ancestor, we resolve to the first match.getSourceComponentNameto acceptFiber["_debugOwner"]and gate withisFiber; behavior unchanged.FiberRootLiketo extendOmit<FiberRoot, "current">sinceFiberRoot.currentis now non‑null.@types/react-reconcileris now pulled viabippy.Written for commit c877aa0. Summary will update on new commits.