-
Notifications
You must be signed in to change notification settings - Fork 337
feat: support grabbing text nodes #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aidenybai
wants to merge
14
commits into
main
Choose a base branch
from
codex/grab-text-nodes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b43bd70
feat: support grabbing text nodes
aidenybai f4ddc31
fix: keep text node feedback aligned
aidenybai 4f95bd3
fix: preserve text targets across actions
aidenybai 3da183d
fix: handle text node edge cases
aidenybai 35201f5
fix: stabilize text node feedback
aidenybai 9a89f22
fix: keep wrapped text anchors stable
aidenybai 7517885
fix: retain transient text targets
aidenybai ae82602
fix: disambiguate text node targets
aidenybai 2dc909b
fix: clear stale text after shift drag
aidenybai 6f1e476
fix: preserve transient text feedback
aidenybai 3e3e5a2
fix: stabilize flaky interaction tests
aidenybai d52f6e9
fix: preserve disconnected text targets
aidenybai ea022e6
fix: harden disconnected text handling
aidenybai 43c0a33
fix: preserve latest text feedback bounds
aidenybai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.