Render overlay canvas in a worker - #591
Draft
aidenybai wants to merge 1 commit into
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OffscreenCanvasWhy
The existing canvas layers still ran their animation and compositing loop on the main thread. This isolates that work where supported while retaining the current canvas behavior in browsers without transferable offscreen canvases.
Validation
nr buildnr typechecknr lintnr formatE2E_ENVIRONMENT=vite-plus-development nr test -- e2e/overlay-canvas-worker.spec.ts e2e/zoom-canvas.spec.ts(164 unit tests and 3 focused browser tests)Summary by cubic
Render the overlay canvas in a dedicated worker via a transferred OffscreenCanvas, with a main-thread fallback. Preserves DPR, Display P3, zoom, and animation behavior, and bundles the worker inline for reliable startup.
New Features
data-react-grab-overlay-backendattribute for observability.Dependencies
esbuildto bundle the inline worker.Written for commit cbc9761. Summary will update on new commits.