feat(sources): warn when sources disagree on a version or a slug - #287
Merged
Conversation
ncrmro
force-pushed
the
feat/detect-ambiguous
branch
from
August 12, 2026 20:38
f77fe4e to
d910a7b
Compare
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds OFTR-004.7 (Ambiguous Source Resolution) with pinned tests and detection in the resolver, per the requirements-governance discipline: canon, tests, and implementation in one change set.
The defect class
Two production incidents this month, one class — ambiguity resolved by silent selection:
actions-agent; source order silently picked the wrong one.community-profiles v1.2.0, which replaced the CI-written settings naming the org catalog wholesale — the org catalog was silently dropped and a run resolved a deleted model (fixed configuration-side in ai-outfitter/wiki#8).Both times
outfitter list agentsprinted the wrong resolution and exited 0.What resolution now warns on
sourceslist replacing a lower scope's list and dropping a declared repository entirely, naming the dropped source, its declaring scope, and the replacing scope. This is the wiki incident's actual shape.Warnings surface through every resolving command (
sync,validate,list agents,run). Precedence is unchanged — detection never alters which declaration wins.First adversarial review REFUTED the initial implementation: it detected same-repo ref conflicts but stayed silent on the wiki incident, because detection ran after
mergeSettingsStackhad discarded the replaced source list. The third bullet and its pinned regression test (the exact incident shape) came out of that review; the fix was verified empirically against the built CLI.A follow-up PR makes
--strictfail on ambiguous resolution instead of warning (the negative half of the "one pin per source" milestone demo).🤖 Generated with Claude Code