Draft
fix: forward leading harness flags when run is the default command#242
Conversation
4 tasks
When `run` is used as the default command, Commander consumes leading flags like `-r` and `--resume` as the optional `[agent]` positional argument. Detect option-shaped agent values (starting with `-`) and reclassify them as pass-through arguments so they reach the harness CLI. Closes #239
Copilot
AI
changed the title
[WIP] Forward Pi flags when run is the default command
fix: forward leading harness flags when run is the default command
Jul 31, 2026
Contributor
|
@copilot please rebase this and fix any merge conflicts |
Copilot stopped work on behalf of
ncrmro due to an error
August 6, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
runacts as the default command, Commander's positional parsing consumes leading flags like-rand--resumeas the optional[agent]argument, producing a misleading "Unknown agent" error instead of forwarding them to Pi.Changes
RunAgentCommand.ts— Detect option-shapedagentvalues (starting with-) in the action handler and reclassify them as pass-through arguments, lettingdefault_agentresolve normally while the flag reaches the harness CLI.run-agent.test.ts— Four new tests:-rforwarding,--resumeforwarding, explicit agent selection preserved,--harness/--strictpreserved alongside forwarding.cli.md— Document the default-command pass-through syntax with examples.Approach
The fix is intentionally narrow — a guard in the action callback rather than restructuring Commander's argument definition. This avoids changing the
[agent]positional contract while correctly handling the ambiguity that only arises through default-command dispatch: