Migrate from re2 to re opam package#199
Draft
thatportugueseguy wants to merge 4 commits intomasterfrom
Draft
Conversation
dune-project
Outdated
| (>= 1.7.8)) | ||
| (lwt | ||
| (>= 5.7.0)) | ||
| (>= 5.7.0 & < 6.0.0)) |
There was a problem hiding this comment.
This causes a devkit builds failure. It is addressed in ahrefs/devkit#55
There was a problem hiding this comment.
hmm this shouldn't cause an issue, but then the CI is actually installing
∗ lwt 6.1.0 [required by monorobot]
∗ lwt_ppx 6.1.0 [required by monorobot]
monorobot.opam
Outdated
Comment on lines
24
to
25
There was a problem hiding this comment.
ah this is not updated!!
that's why the CI gets the error
* master: Add dev server info to the README Update Makefile target order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the task
migrate away from re2 to be able to upgrade to trixie.
Opening a PR to check if other dependencies need to be migrated too