buildpackage: Include uncommitted changes with --git-ignore-new and export-dir#99
Open
samueloph wants to merge 1 commit into
Open
buildpackage: Include uncommitted changes with --git-ignore-new and export-dir#99samueloph wants to merge 1 commit into
samueloph wants to merge 1 commit into
Conversation
…xport-dir With --git-export-dir set, the tree to export defaulted to HEAD, so --git-ignore-new silently dropped uncommitted changes. This was inconsistent with building in-place (no export-dir), which builds the working copy and therefore includes them. The option is documented as "Build with uncommitted changes in the source tree", so the changes should end up in the build regardless of export-dir. Export the working copy when --git-ignore-new is given and --git-export is left at its default (HEAD). Closes: #1091531
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --git-export-dir set, the tree to export defaulted to HEAD, so --git-ignore-new silently dropped uncommitted changes. This was inconsistent with building in-place (no export-dir), which builds the working copy and therefore includes them. The option is documented as "Build with uncommitted changes in the source tree", so the changes should end up in the build regardless of export-dir.
Export the working copy when --git-ignore-new is given and --git-export is left at its default (HEAD).
Closes: #1091531
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091531