Skip to content

fix: deal with arcgis package breaking change#195

Merged
stdavis merged 1 commit into
mainfrom
stdavis-patch-1
Jun 23, 2026
Merged

fix: deal with arcgis package breaking change#195
stdavis merged 1 commit into
mainfrom
stdavis-patch-1

Conversation

@stdavis

@stdavis stdavis commented Jun 22, 2026

Copy link
Copy Markdown
Member

This must have broke at 2.4.3 or around there. Here is the source code for Table.fromitem

class Table(FeatureLayer):
    """
    ``Table`` objects represent entity classes with uniform properties. In addition to working with
    "entities with location" as :class:`~arcgis.features.Feature` objects, the :class:`~arcgis.gis.GIS` can also work
    with non-spatial entities as rows in tables.

    .. note::
        Working with tables is similar to working with :class:`~arcgis.features.FeatureLayer`objects, except that the
        rows (Features) in a table do not have a geometry, and tables ignore any geometry related operation.
    """

    @classmethod
    def fromitem(cls, item: Item, layer_id: int = None, id_property: int = None):

This must have broke at 2.4.3 or around there. Here is the source code for `Table.fromitem`

```python
class Table(FeatureLayer):
    """
    ``Table`` objects represent entity classes with uniform properties. In addition to working with
    "entities with location" as :class:`~arcgis.features.Feature` objects, the :class:`~arcgis.gis.GIS` can also work
    with non-spatial entities as rows in tables.

    .. note::
        Working with tables is similar to working with :class:`~arcgis.features.FeatureLayer`objects, except that the
        rows (Features) in a table do not have a geometry, and tables ignore any geometry related operation.
    """

    @classmethod
    def fromitem(cls, item: Item, layer_id: int = None, id_property: int = None):
```

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates ServiceUpdater initialization to accommodate an ArcGIS Python API breaking change around Table.fromitem() parameter naming (moving away from table_id).

Changes:

  • Updates Table.fromitem() invocation to no longer use the table_id= keyword.
  • Updates FeatureLayer.fromitem() invocation to pass the layer/table index as the second argument.

Comment thread src/palletjack/load.py
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.10%. Comparing base (f87f4c5) to head (2654c1c).
⚠️ Report is 147 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   94.52%   96.10%   +1.57%     
==========================================
  Files           7        6       -1     
  Lines        1133     1360     +227     
  Branches      148      155       +7     
==========================================
+ Hits         1071     1307     +236     
+ Misses         52       43       -9     
  Partials       10       10              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stdavis stdavis enabled auto-merge (rebase) June 22, 2026 23:38
@stdavis stdavis requested a review from acneville June 22, 2026 23:38
@stdavis stdavis merged commit 97537e5 into main Jun 23, 2026
8 checks passed
@stdavis stdavis deleted the stdavis-patch-1 branch June 23, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants