fix: deal with arcgis package breaking change#195
Merged
Conversation
This must have broke at 2.4.3 or around there. Here is the source code for `Table.fromitem`
```python
class Table(FeatureLayer):
"""
``Table`` objects represent entity classes with uniform properties. In addition to working with
"entities with location" as :class:`~arcgis.features.Feature` objects, the :class:`~arcgis.gis.GIS` can also work
with non-spatial entities as rows in tables.
.. note::
Working with tables is similar to working with :class:`~arcgis.features.FeatureLayer`objects, except that the
rows (Features) in a table do not have a geometry, and tables ignore any geometry related operation.
"""
@classmethod
def fromitem(cls, item: Item, layer_id: int = None, id_property: int = None):
```
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ServiceUpdater initialization to accommodate an ArcGIS Python API breaking change around Table.fromitem() parameter naming (moving away from table_id).
Changes:
- Updates
Table.fromitem()invocation to no longer use thetable_id=keyword. - Updates
FeatureLayer.fromitem()invocation to pass the layer/table index as the second argument.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 94.52% 96.10% +1.57%
==========================================
Files 7 6 -1
Lines 1133 1360 +227
Branches 148 155 +7
==========================================
+ Hits 1071 1307 +236
+ Misses 52 43 -9
Partials 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
acneville
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This must have broke at 2.4.3 or around there. Here is the source code for
Table.fromitem