Skip to content

feat: use new errors pkg in pkg/cloudproduct/* - #4712

Merged
markmandel merged 2 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-in-cloudproduct-pkg
Sep 5, 2026
Merged

feat: use new errors pkg in pkg/cloudproduct/*#4712
markmandel merged 2 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-in-cloudproduct-pkg

Conversation

@lacroixthomas

Copy link
Copy Markdown
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:

Use the new error package (https://github.com/agones-dev/agones/blob/main/pkg/util/errors/errors.go) on the pkg/cloudproduct/* files

Which issue(s) this PR fixes:
Work on #4510

Did you use AI tools in preparing this PR?:
Y

Special notes for your reviewer:

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@lacroixthomas
lacroixthomas requested a review from a team September 3, 2026 22:45
@lacroixthomas
lacroixthomas marked this pull request as ready for review September 3, 2026 22:45
@github-actions github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Sep 3, 2026
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 15bccbaa-69ab-429f-aa52-d5b8f9350d14

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy approve

@markmandel
markmandel enabled auto-merge (squash) September 5, 2026 01:45
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: e59d50b7-bda1-4ddc-835e-8e067664eaab

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel

Copy link
Copy Markdown
Member

/gcbrun

Cloud Build is being super grumpy lately

ERROR: build step 1 "e2e-runner" failed: failed to copy output from container: Error response from daemon: error while mounting volume '/var/lib/docker/volumes/step-1-c71dc8ee-3354-4300-b945-f451c819b5a1/_data': get step-1-c71dc8ee-3354-4300-b945-f451c819b5a1: database not open

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 04a90579-25a9-4507-9075-4d036a5f9469

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4712/head:pr_4712 && git checkout pr_4712
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-19725c1

@markmandel
markmandel merged commit 1afb494 into agones-dev:main Sep 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants