Skip to content

feat: use new errors pkg in pkg/fleets/* - #4710

Merged
markmandel merged 2 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-fleets-pkg
Sep 5, 2026
Merged

feat: use new errors pkg in pkg/fleets/*#4710
markmandel merged 2 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-fleets-pkg

Conversation

@lacroixthomas

Copy link
Copy Markdown
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:

Use the new error package (https://github.com/agones-dev/agones/blob/main/pkg/util/errors/errors.go) on the pkg/fleets/* files

Which issue(s) this PR fixes:
Work on #4510

Did you use AI tools in preparing this PR?:
Y

Special notes for your reviewer:

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@lacroixthomas
lacroixthomas marked this pull request as ready for review September 3, 2026 22:14
@lacroixthomas
lacroixthomas requested a review from a team September 3, 2026 22:15
@github-actions github-actions Bot added size/S kind/cleanup Refactoring code, fixing up documentation, etc labels Sep 3, 2026
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: d6cab5f4-82f8-4c26-bc94-9042493f992e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas

Copy link
Copy Markdown
Collaborator Author

/gcbrun

Step #24 - "push-upgrade-test": 123.7 /go/pkg/mod/github.com/sagikazarmark/locafero@v0.12.0/finder.go:10:2: github.com/spf13/afero@v1.15.0: read "https://proxy.golang.org/github.com/spf13/afero/@v/v1.15.0.zip": stream error: stream ID 61; INTERNAL_ERROR; received from peer
Step #24 - "push-upgrade-test": 123.7 /go/pkg/mod/github.com/fxamacker/cbor/v2@v2.9.0/decode.go:23:2: github.com/x448/float16@v0.8.4: read "https://proxy.golang.org/github.com/x448/float16/@v/v0.8.4.zip": stream error: stream ID 203; INTERNAL_ERROR; received from peer
Step #24 - "push-upgrade-test": 123.7 /go/pkg/mod/agones.dev/agones@v1.54.0/pkg/apis/agones/v1/gameserver.go:30:2: gomodules.xyz/jsonpatch/v2@v2.5.0: read "https://proxy.golang.org/gomodules.xyz/jsonpatch/v2/@v/v2.5.0.zip": stream error: stream ID 13; INTERNAL_ERROR; received from peer
Step #24 - "push-upgrade-test": ------
Step #24 - "push-upgrade-test": ERROR: failed to solve: executor failed running [/bin/sh -c CGO_ENABLED=0 GOOS=linux go build -o /upgrade-test]: exit code: 1
Step #24 - "push-upgrade-test": make: *** [Makefile:44: build] Error 1
Finished Step #24 - "push-upgrade-test"

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 5f2e904e-4d0d-4067-99b2-911a3823fad9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4710/head:pr_4710 && git checkout pr_4710
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-ea4392d

@markmandel
markmandel enabled auto-merge (squash) September 5, 2026 20:14
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 245ceca3-9dde-4bd2-874f-4061d03e278e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4710/head:pr_4710 && git checkout pr_4710
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-97a27fd

@markmandel
markmandel merged commit c405f48 into agones-dev:main Sep 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants