Skip to content

feat: use new errors pkg in pkg/gameserverset/* - #4703

Open
lacroixthomas wants to merge 5 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-gamesersets-okg
Open

feat: use new errors pkg in pkg/gameserverset/*#4703
lacroixthomas wants to merge 5 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-gamesersets-okg

Conversation

@lacroixthomas

Copy link
Copy Markdown
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:

Use the new error package (https://github.com/agones-dev/agones/blob/main/pkg/util/errors/errors.go) on the pkg/gameserversts/* files

Which issue(s) this PR fixes:
Work on #4510

Did you use AI tools in preparing this PR?:
Y

Special notes for your reviewer:

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@github-actions github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Aug 31, 2026
@lacroixthomas
lacroixthomas marked this pull request as ready for review August 31, 2026 22:57
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: b2087f80-8f9e-4094-ab03-47a4e81ccb35

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 17199340-92b7-42c8-a447-2b9a4f91d288

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4703/head:pr_4703 && git checkout pr_4703
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-3ae1bfc

@markmandel markmandel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one docs.go thing, otherwise good to go.

Comment thread pkg/gameserversets/doc.go Outdated
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 23748ba0-e6bf-4e68-af8f-2f688f404904

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4703/head:pr_4703 && git checkout pr_4703
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-d6ba2e1

@markmandel
markmandel enabled auto-merge (squash) September 6, 2026 23:32
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: d4bb0d08-966d-4abf-97f6-f8d5a6db4016

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants