feat: use new errors pkg in pkg/gameserverallocations/* - #4701
Conversation
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
|
Build Failed 😭 Build Id: 4393800c-c8fd-467c-8b02-536c7dcfa311 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
|
Build Failed 😭 Build Id: 6282e303-2e50-42d0-8aed-2e69124d4dac Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 🥳 Build Id: aea2c297-e638-4554-97d6-b95ed03836b4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
markmandel
left a comment
There was a problem hiding this comment.
Question around docs.go (maybe a rename on the file?) - but approving - merge when you've worked out what you want to do about that nit.
| gsList, err := c.gameServerLister.List(labels.Everything()) | ||
| if err != nil { | ||
| return errors.Wrap(err, "could not list GameServers") | ||
| return c.errs.Wrap(err, "could not list GameServers") |
There was a problem hiding this comment.
Loving how easy this is with the wrapper.
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
|
Build Succeeded 🥳 Build Id: 82a59d1d-1bc1-4fe3-b324-f140e2fc49e5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Use the new error package (https://github.com/agones-dev/agones/blob/main/pkg/util/errors/errors.go) on the pkg/gameserverallocations/* files
Which issue(s) this PR fixes:
Work on #4510
Did you use AI tools in preparing this PR?:
Y
Special notes for your reviewer: