Skip to content

feat: use new errors pkg in pkg/gameserverallocations/* - #4701

Merged
markmandel merged 6 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-gameserverallocation-pkg
Sep 4, 2026
Merged

feat: use new errors pkg in pkg/gameserverallocations/*#4701
markmandel merged 6 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-gameserverallocation-pkg

Conversation

@lacroixthomas

Copy link
Copy Markdown
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:

Use the new error package (https://github.com/agones-dev/agones/blob/main/pkg/util/errors/errors.go) on the pkg/gameserverallocations/* files

Which issue(s) this PR fixes:

Work on #4510

Did you use AI tools in preparing this PR?:

Y

Special notes for your reviewer:

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@github-actions github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Aug 31, 2026
@lacroixthomas
lacroixthomas marked this pull request as ready for review August 31, 2026 21:38
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 4393800c-c8fd-467c-8b02-536c7dcfa311

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 6282e303-2e50-42d0-8aed-2e69124d4dac

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: aea2c297-e638-4554-97d6-b95ed03836b4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4701/head:pr_4701 && git checkout pr_4701
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-8e9b64c

@markmandel markmandel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question around docs.go (maybe a rename on the file?) - but approving - merge when you've worked out what you want to do about that nit.

gsList, err := c.gameServerLister.List(labels.Everything())
if err != nil {
return errors.Wrap(err, "could not list GameServers")
return c.errs.Wrap(err, "could not list GameServers")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving how easy this is with the wrapper.

Comment thread pkg/gameserverallocations/doc.go Outdated
@markmandel
markmandel enabled auto-merge (squash) September 3, 2026 22:58
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 82a59d1d-1bc1-4fe3-b324-f140e2fc49e5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4701/head:pr_4701 && git checkout pr_4701
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-a9cf5db

@markmandel
markmandel merged commit a1e565b into agones-dev:main Sep 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants