fix(webpack-plugin): inject client runtime module in watch mode only - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WebpackBuildStatsPluginadded the DevFeedback browser runtime (referenceswindow,WebSocket,MutationObserver,module.hot) to every initial chunk of every compilation — including one-off production/CI builds.Real-world breakages from the 2.0.9 batch rollout:
build-clientside-for-test): html-webpack-plugin compilespublic/index.htmlin a child compilation; the injected runtime ends up in the compiled template which html-webpack-plugin then evaluates vianode:vm→Error: window is not defined→ build fails.Agoda.SupplyLayout.SsrClientSide): the same runtime would be executed in Node on server startup →window is not definedcrash.localhost, which is meaningless outside local dev.Fix
compiler.watchModeis true (webpack dev server /--watch) — the snippet exists to report HMR/DOM-update events during local development; it serves no purpose in one-off builds.typeof window === 'undefined' || typeof document === 'undefined'early-return in the generated client code, so any future accidental evaluation outside a browser is a no-op instead of a crash.Build-stats collection (
compile/donehooks) is unaffected and still runs in all builds.Tests