Skip to content

Broken GitHub notebook link agenteval_cq_math.ipynb returns 404#2676

Closed
VasiliyRad wants to merge 1 commit intomainfrom
elva/fix-052f951c
Closed

Broken GitHub notebook link agenteval_cq_math.ipynb returns 404#2676
VasiliyRad wants to merge 1 commit intomainfrom
elva/fix-052f951c

Conversation

@VasiliyRad
Copy link
Copy Markdown
Contributor

Files changed:

  • website/docs/_blogs/2023-11-20-AgentEval/index.mdx

Took me two passes to get this right — first attempt missed the mark.

What I checked before submitting:

The round-2 fix cleanly addresses both the bug and the round-1 prose feedback.

What was fixed:

  • Both broken links to https://github.com/ag2ai/ag2/blob/main/notebook/agenteval_cq_math.ipynb (confirmed HTTP 404) have been removed.

Quality of edits:

  1. First occurrence (TL;DR bullet): The phrase "as an example in the following notebook" is trimmed to "as an example." — the sentence flows naturally and reads correctly.
  2. Second occurrence (body paragraph): "For reference, use the following notebook." is removed cleanly, leaving a well-formed sentence ending with "(Fig. 1)."

No regressions: no link replacements (only deletions of dead links), no YAML frontmatter changes, the valid math problems dataset link is preserved intact.

This is a correct, minimal, and readable fix — ready to ship.


Like a river carves its path — small, steady changes shape the landscape. Fixed by Elva.

… returns 404

GitHub notebook file agenteval_cq_math.ipynb returns HTTP 404.

Bug: file-052f951c
Fixed by Elva.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Elva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 15, 2026
@VasiliyRad
Copy link
Copy Markdown
Contributor Author

Duplicate — #2677 fixes the link instead of removing it.

@VasiliyRad VasiliyRad closed this Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants