Skip to content

Broken localhost link in WebSockets blog post#2674

Merged
marklysze merged 1 commit intomainfrom
elva/fix-0128a2f8
Apr 20, 2026
Merged

Broken localhost link in WebSockets blog post#2674
marklysze merged 1 commit intomainfrom
elva/fix-0128a2f8

Conversation

@VasiliyRad
Copy link
Copy Markdown
Contributor

Files changed:

  • website/docs/_blogs/2025-01-10-WebSockets/index.mdx

What I checked before submitting:

The fix correctly resolves the broken localhost link by converting [http://localhost:8001/](http://localhost:8001/) to inline code `http://localhost:8001/`. Since localhost URLs are development-time addresses that are only meaningful when the user is running the demo locally, they should never appear as clickable hyperlinks in public documentation — they will always be dead links for readers who aren't running the server. Rendering it as inline code preserves the instructional intent (telling the user what URL to open in their browser) while removing the broken link. The change is minimal, targeted, and consistent with standard MDX/Markdown documentation conventions.


Like a river carves its path — small, steady changes shape the landscape. Fixed by Elva.

WebSockets blog post contains unreachable localhost:8001/ hyperlink.

Bug: file-0128a2f8
Fixed by Elva.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Elva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 15, 2026
Copy link
Copy Markdown
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VasiliyRad, not critical adjustment but happy to have it in.

@marklysze marklysze merged commit faa187b into main Apr 20, 2026
24 of 25 checks passed
@marklysze marklysze deleted the elva/fix-0128a2f8 branch April 20, 2026 01:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants