allow loading content through byte streams.#299
Open
daoyeppl wants to merge 4 commits into
Open
Conversation
dnesting
reviewed
Feb 18, 2024
|
|
||
| def _load(self): | ||
| if os.path.isdir(self.file_name): | ||
| if isinstance(self.file_name, str) and os.path.isdir(self.file_name): |
There was a problem hiding this comment.
I'm just a bystander, and I'm not sure what kind of Python version compatibility this is striving for, but in more recent versions of Python, this might be more accurate:
if isinstance(self.file_name, (str, bytes, os.PathLike))Either way this patch is what I came here to find, so thank you.
|
您好！您的来信我已接受，我会尽快回复您。
|
If filename is not str or PathLike, do not use isdir detection and directly use ZipFile to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.