Skip to content

Updated default wix version from 5.0.0 to 5.0.2#1136

Merged
gdams merged 2 commits into
adoptium:masterfrom
jmjaffe37:jmj/wix_5.0.2
Mar 7, 2025
Merged

Updated default wix version from 5.0.0 to 5.0.2#1136
gdams merged 2 commits into
adoptium:masterfrom
jmjaffe37:jmj/wix_5.0.2

Conversation

@jmjaffe37
Copy link
Copy Markdown
Contributor

Tested with Microsoft installers, behavior is as expected

@gdams
Copy link
Copy Markdown
Member

gdams commented Mar 5, 2025

@jmjaffe37 can you raise a PR to update https://github.com/adoptium/infrastructure/blob/a66be376adb9b1ab3aff08b38523f9736e8cd1f4/ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/WiX/tasks/main.yml#L7. We'll need to merge this and run the ansible playbook first before merging this

@jmjaffe37
Copy link
Copy Markdown
Contributor Author

@jmjaffe37 can you raise a PR to update https://github.com/adoptium/infrastructure/blob/a66be376adb9b1ab3aff08b38523f9736e8cd1f4/ansible/playbooks/AdoptOpenJDK_Windows_Playbook/roles/WiX/tasks/main.yml#L7. We'll need to merge this and run the ansible playbook first before merging this

@gdams, I have just finished making that PR. Here is the link: adoptium/infrastructure#3899

@jmjaffe37 jmjaffe37 requested a review from karianna March 5, 2025 17:30
@jmjaffe37
Copy link
Copy Markdown
Contributor Author

@gdams, now that the PR you requested has been merged, would you be able to give this PR another review (and potentially an approval)? Thank you in advance :)

@gdams gdams merged commit e840f3b into adoptium:master Mar 7, 2025
@jmjaffe37 jmjaffe37 deleted the jmj/wix_5.0.2 branch March 7, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants