tools: Machine audit - backend scripts to run on Nagios server#4357
Open
Haroon-Khel wants to merge 2 commits into
Open
tools: Machine audit - backend scripts to run on Nagios server#4357Haroon-Khel wants to merge 2 commits into
Haroon-Khel wants to merge 2 commits into
Conversation
steelhead31
reviewed
May 22, 2026
| def main(): | ||
|
|
||
| # Jenkins credentials from command line | ||
| url, username, password = sys.argv[1:4] |
Contributor
There was a problem hiding this comment.
I'd recommend adding some validation akin to
if len(sys.argv) < 4: print("Usage: ..."); sys.exit(1)
Python has a habit of crashing if an argument is missing
| scp_command = [ | ||
| "scp", | ||
| "-P", port, | ||
| "-o", "StrictHostKeyChecking=no", |
Contributor
There was a problem hiding this comment.
Semgrep will likely flag this as an issue, might be worth trying it without this flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re #4334
Backend scripts to run on the Nagios server.
collecedInfo/{node_name}_machine_info.jsonThings i need to do to test this pr:
machine_info.jsonon each machine