Skip to content

Contain tables - #138

Closed
marissahuysentruyt wants to merge 6 commits into
mainfrom
contain-tables
Closed

marissahuysentruyt wants to merge 6 commits into
mainfrom
contain-tables

Conversation

@marissahuysentruyt

Copy link
Copy Markdown
Collaborator

Description

Screenshots (if applicable)

Type of change

  • Bug fix
  • New feature / block
  • Refactor
  • Docs / content
  • Chore (deps, config, tooling)

Related issue(s)

  • fixes [Issue Number]

Validation steps

  • This PR has visual elements, so it was reviewed by a designer.
  • This PR has code changes, and our linters still pass.
  • This PR affects production code, so it was browser tested (see below).
  • This PR affects existing pages, so automated E2E tests were run (see below).
  • This PR has new code, so new tests were added or updated, and they pass.
  • This PR has copy changes, so copy was proofread and approved.
  • The content of this PR requires documentation, so a detailed description of the component's purpose, requirements, quirks, and instructions for use by designers and developers was added, along with accessibility information if pertinent.

To Validate

URL for testing:
https://--spectrum-hub--adobe.aem.page/

  • Make sure all PR Checks have passed
  • Pull down the branch locally or visit the branch preview
  • Run npm test and confirm all tests pass
  • Run npm run lint and confirm no linting errors
  • Verified in browser with aem up

Accessibility testing checklist

  • Keyboard
  1. Go here
  2. Do this action
  3. Expect this result
  • Screen reader
  1. Go here
  2. Do this action
  3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync

aem-code-sync Bot commented Sep 14, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@marissahuysentruyt

Copy link
Copy Markdown
Collaborator Author

TODO: fix the table margin-block-start (similar to the fix in the columns block for non-grid columns from #137

@marissahuysentruyt

Copy link
Copy Markdown
Collaborator Author

closing this PR. the scrollable container was addressed here: #223

This branch was successfully deployed

1 active deployment
contain-tables — d878ddba Deployed Sep 11, 2026 by aem-code-sync[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❌ Do not merge This is not for merging. 🚧 WIP Work in progress, don't judge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant