fix: include stepStateText in StepListItem accessible name#9888
Open
Krishnachaitanyakc wants to merge 1 commit intoadobe:mainfrom
Open
fix: include stepStateText in StepListItem accessible name#9888Krishnachaitanyakc wants to merge 1 commit intoadobe:mainfrom
Krishnachaitanyakc wants to merge 1 commit intoadobe:mainfrom
Conversation
Add the VisuallyHidden stepStateText element to the aria-labelledby of each StepListItem link so screen readers announce the step state (Current/Completed/Not completed) as part of the accessible name. This ensures conformance with WCAG SC 2.5.3 Label in Name (Level A) by including the visually hidden but rendered step state text in the computed accessible name for each step. Closes adobe#9881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9881
✅ Pull Request Checklist:
📝 Test Instructions:
StepListwith multiple items and various completion statesaria-labelledbyattribute — it should reference three IDs: the marker number, the step state text (Current/Completed/Not completed), and the labelyarn jest --no-watchman packages/@adobe/react-spectrum/test/steplist/StepList.test.tsx🧢 Your Project:
Open source accessibility contribution