[WIP] docs(S2): add Custom Components docs and Examples page#9886
Open
reidbarber wants to merge 1 commit intomainfrom
Open
[WIP] docs(S2): add Custom Components docs and Examples page#9886reidbarber wants to merge 1 commit intomainfrom
reidbarber wants to merge 1 commit intomainfrom
Conversation
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new "Custom Components" page to the S2 docs and an "Examples" page, similar to how we have for React Aria.
I'm still on the fence about the content, since there is a decent amount of overlap with the existing Styling docs, but it seems like we need better guidance towards combining React Aria Components + the S2 Style macro for creating custom S2 components.
We'll also need to think through what makes good "examples" and doesn't get too close to existing components.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: