Skip to content

fix(S2): fix Combobox styles to shift button 2px closer to end #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LFDanLu merged 1 commit into from
Apr 9, 2026
+1 −2
Merged

fix(S2): fix Combobox styles to shift button 2px closer to end #9882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/@react-spectrum/s2/src/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,8 +624,7 @@ const ComboboxInner = forwardRef(function ComboboxInner(props: ComboBoxProps<any
paddingStart: 'edge-to-text',
// better way to do this one? it's not actually half, they are
// [9, 4], [12, 6], [15, 8], [18, 8]
// also noticed that our measurement is including the border, making the padding too much
paddingEnd: 'calc(self(height, self(minHeight)) * 3 / 16)'
paddingEnd: 'calc(self(height, self(minHeight)) * 3 / 16 - self(borderEndWidth, 2px))'
})({size})}>
<InputContext.Consumer>
{ctx => (
Expand Down
Loading