Merged
Conversation
# Conflicts: # packages/@react-spectrum/s2/src/Calendar.tsx # packages/@react-spectrum/s2/src/DateRangePicker.tsx
# Conflicts: # packages/@react-spectrum/s2/src/RangeCalendar.tsx
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Member
Author
|
This comment is no longer relevant, all comments it cited have apparently been deleted |
devongovett
approved these changes
Mar 30, 2026
Member
|
mind adding some testing instructions? helpful when it comes to the testing sheet |
yihuiliao
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Follows the pattern in the starter kits so that when the screen gets smaller, we can still fit the calendar without horizontal scrolling. To an extent. When things get really narrow, since we don't apply scaling down but rather only scaling up, on the prev/next buttons, they will become unaligned, this is expected.
Note, this only applies to a single visible month, if there are more visible months it should behave the same as before. Eventually, we'll determine the number of actual max visible months based on available space, not just the prop.
Important, if you're using Chrome dev tools to dynamic responsive resize, sometimes it can mess up, either refresh the page, or toggle the responsive mode off and on again, or do both things, see if it works then.
✅ Pull Request Checklist:
📝 Test Instructions:
Go to Calendar/RangeCalendar/DatePicker/DateRangePicker
Make sure they look good (unchanged) at desktop size. Visit on mobile, the cells may be a little smaller so that the entire calendar can fit in the viewport.
This only affects single month views.
Important, if you're using Chrome dev tools to dynamic responsive resize, sometimes it can mess up, either refresh the page, or toggle the responsive mode off and on again, or do both things, see if it works then.
🧢 Your Project: