Repository navigation
fix(e2e): replace deprecated Helm atomic install flag - #363
Merged
Merged
Conversation
Use Helm 4 rollback-on-failure and update related comments. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the deprecated
--atomicinstall flag with--rollback-on-failurein the shared e2e Helm installer. CI already pins Helm 4.3.0. The replacement continues to enable readiness waiting and uninstall failed installations. Update related comments in the Contour configuration and CI diagnostics.Helm reference: https://helm.sh/docs/helm/helm_install/
Local e2e runs now require Helm 4; Helm 3 does not support the replacement flag.
Validation:
go test -C tests/e2e -run '^$' .— passed; compiles the package without executing tests.go test -C tests/e2e -tags e2e -run '^$' .— passed; compiles with the e2e build tag without executing tests.gofmt -l tests/e2e/helm.go tests/e2e/global.go— passed; no formatting changes required.git diff --check— passed.make test-e2e— not run locally; local Helm is 3.17.1. The PR's e2e workflow uses Helm 4.3.0.make lint/make check— not run locally; the repository golangci-lint binary is unavailable. CI checks will provide lint and full test results.Type of Change
Checklist