Skip to content

fix: align preview rendering and video routing with AEM - #336

Draft
hannessolo wants to merge 1 commit into
mainfrom
ewfixes
Draft

hannessolo wants to merge 1 commit into
mainfrom
ewfixes

Conversation

@hannessolo

Copy link
Copy Markdown
Collaborator

Summary

Addresses the server-side issues tracked by adobe/da-live#1688:

Related drafts

These are coordinated cross-repository changes, not stacked branches.

Validation

  • npm test -- --reporter dot: 573 passing (full suite).
  • npm run lint: passes; existing ESLint-env migration warnings remain.
  • git diff --check: passes.
  • Regression tests cover routing through the actual GET/HEAD handlers and AEM proxy, Range/206 and media headers, authentication, upstream errors, rendering-mode selection and route propagation, metadata precedence/empty semantics, structured section values, and empty block/cell handling.
  • Local Chrome check: generated an original MP4, decoded and played it inside an iframe through the actual handlers/proxy with a mocked AEM upstream. Confirmed a browser-issued Range request, 206 response, site-token forwarding, and a bodyless HEAD. Browser and local server were stopped afterward.

Not deployed. Production Experience Workspace/canvas validation against the affected sites remains pending; the local playback check is a synthetic iframe fixture, not a deployed canvas session.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hannessolo

Copy link
Copy Markdown
Collaborator Author

Scope clarification for adobe/da-live#1695: adobe/da-live#1704 already fixed the da-live client-preview rendering-mode gate and legacy metadata preservation. Its stated scope explicitly excludes initial server-rendered HTML and standalone previews.

The #1695 work here is the remaining da-universal initial-rendering path: propagate the effective site rendering mode, preserve legacy section-metadata blocks, and extract structured values correctly for rendering v2. This does not duplicate the merged da-live fix.

Related drafts: adobe/da-nx#992 covers standalone Quick Edit; adobe/da-live#1725 covers remaining structured-value extraction and empty-cell/block serialization. Production-site validation remains pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant