Repository navigation
fix(desktop): pin the M7 visual capture to dark themes - #2511
Merged
Merged
Conversation
Cortana pins its appearance to dark, but the M7 visual capture still accepted any catalogue theme id: a light theme produced screenshots the audit mislabeled as valid appearance states. Resolve the legacy `blue` preference to `nord`, reject any requested theme outside the dark catalogue, and verify the page's actual `data-theme`/`data-appearance` before naming or saving a screenshot, so a render that applied the wrong theme fails the audit instead of being recorded. Document the contract alongside the capture workflow.
0xPlayerOne
changed the title
0xPlayerOne
marked this pull request as ready for review
October 5, 2026 17:13
0xPlayerOne
marked this pull request as draft
October 5, 2026 18:40
0xPlayerOne
marked this pull request as ready for review
October 5, 2026 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI PR created automatically by this workflow.
This PR is intentionally opened as a draft. Mark it ready for review
when the proposed change is ready to start required validation.
CI Status: Pending — this workflow triggered on push to fix/m7-capture-dark-only.