feat: support null and undefined in stringify cast options#484
Merged
Conversation
wdavidw
force-pushed
the
feature/cast-null-undefined
branch
from
83d301b to
6c51f2b
Compare
Member
|
@vishwakt thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #440.
I noticed the issue had been open for some time and wanted to help push it forward.
Instead of introducing new root-level options, this PR implements
cast.nullandcast.undefined. I felt that this approach is more aligned with the project's existing design and allows users to easily emit unquoted null strings (likeNULLor\N) by simply returning{ value: "NULL", quoted: false }.Full test coverage is included and added more tests to support the new code.