Added getAlarmedState() function#320
Open
CoolEou wants to merge 2 commits into
Open
Conversation
Contributor
|
Note that the CI failure is due to clang-format complaining that there should be a space before the opening brace: --- ./src/RTC_DS3231.cpp (original)
+++ ./src/RTC_DS3231.cpp (reformatted)
@@ -356,7 +356,7 @@
@return False if interrupt flag is not set, otherwise true
*/
/**************************************************************************/
-bool RTC_DS3231::getAlarmedState(uint8_t alarm_num){
+bool RTC_DS3231::getAlarmedState(uint8_t alarm_num) {
uint8_t alarmedState = read_register(DS3231_CONTROL);
alarmedState &= (1 << (alarm_num - 1));
return alarmedState; |
Contributor
|
This is functionally equivalent to my PR that has been pending since 2022 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a function that checks the interrupt flag of either of the two alarms on the DS3231. The name of the function could maybe be better, but other than that i haven't touched anything other than adding this function, so everything else should still work as normal, my change only adds a little bit of functionality to the library.
I needed this function to control an indicator LED that indicates to the user whether the alarm is active or not (indicating whether the alarm will go off at the alarm time or not).