Default constructors added for DateTime and TimeSpan classes#318
Open
solamyl wants to merge 2 commits into
Open
Default constructors added for DateTime and TimeSpan classes#318solamyl wants to merge 2 commits into
solamyl wants to merge 2 commits into
Conversation
- default constructor mainly for `DateTime` class and less necessary for `TimeSpan` class - it is always good practise to keep the default constructor as simple as possible, because it may be called very often in same cases - another think is, that the "default parameter" consumes extra memory, because it has to be "compiled-in" in every call.
Author
|
hm, it seems that clang-format.py failed. I have tried to mimic your coding style as much as I could, but probably was wrong with 1 linefeed... |
- just polishing the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
please add the default constructors for the
DateTimeandTimeSpanclasses (this proposed pull request, it is a simple change).longand you have many calls, then hudreds of bytes will be wasted.thank you in advance :-)
-- stepan