Skip to content

Avoid buffer overflow on invalid DateTime #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drak7 merged 1 commit into from
Aug 6, 2020
Merged

Avoid buffer overflow on invalid DateTime #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RTClib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ bool DateTime::operator==(const DateTime &right) const {
*/
/**************************************************************************/
String DateTime::timestamp(timestampOpt opt) {
char buffer[20];
char buffer[25]; // large enough for any DateTime, including invalid ones

// Generate timestamp according to opt
switch (opt) {
Expand Down