chore!: Remove deprecated seeding components

[andiwand]

Removed the already deprecated seeding components in Core/include/Acts/Seeding which have been replaced by Core/include/Acts/Seeding2. A future PR will rotate the component name back to the original one

--- END COMMIT MESSAGE ---

[github-actions]

📊: Physics performance monitoring for 0c404d7

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ ML Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding
• 🔵️ Comparison - Truth tracking (GX2F vs KF)

❗️: Downstream build failure

• eic-shell EICrecon (cc @acts-project/epic-contacts)

❗️: Downstream build failure

• Key4hep (cc @acts-project/key4hep-contacts)

[andiwand]

fyi @osbornjd this might be a bigger chunk to absorb on your side

[osbornjd]

Thanks for the notification - what is the motivation for this? Is this deprecating the grid based seed finder?

[andiwand]

Thanks for the notification - what is the motivation for this? Is this deprecating the grid based seed finder?

the seeding has beed rewritten and currently lives in Seeding2. overall this is supposed to be functionally equivalent but the interface changed completely. besides this the EDM is not completely defined within ACTS. the Examples exercise this

[osbornjd]

If the interface changed completely, is there an obvious mapping from the Seeding interface to Seeding2 interface? Or will we be effectively having to retune our implementation of the seeding algorithm?

[andiwand]

If the interface changed completely, is there an obvious mapping from the Seeding interface to Seeding2 interface? Or will we be effectively having to retune our implementation of the seeding algorithm?

I cannot say if it very obvious. the config params should be mostly the same but got shuffled around. arriving at the exact same performance might take some iterations.

we can discuss this further in the next meeting. I believe we can also offer to delay the removal if that helps. but I should also mention that we are pushing this already for quite some time while mentioning this switchover many times in past meetings

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[asalzburger]

Looks like we need to make and help with the migration here.
ACTS runs in default already in Seeding2 and that will turn into the sole Seeding schema.

@osbornjd what release are you currently running with & what are your next, planned update?

On a side note: we are almost finished with defining the experiment contact group and structure, which is exactly the place where these longer term planning items will be discussed in the future.