build(detray): Fix vecmem CMake include#5490
Conversation
stephenswat
force-pushed
the
build/detray_fixes
branch
from
7e3b4e1 to
d3d9a34
Compare
|
Sorry, made a change to this. Instead of unconditionally including that file, I believe it should actually not be included at all when using an installed version of vecmem. |
|
Slightly related to this PR, and because building ACTS in the LCG stacks failed today, so now vecmem is required by default (and also in the future)? It's a bit weird that it broke today since the default was turned ON a few days ago, that I don't understand yet. Will detray also be required by default? |
@jmcarcell a few more details were shared here https://mattermost.web.cern.ch/acts/pl/jbuxpdkyh3b18y9o48pepmcx3o |
Hi Juan, what broke in this case is a line inside of the detray configuration. vecmem has been enabled by default for a while now. Similarly, detray has been enabled for a while. However, it is only as of #5462 that turning on the detray code actually does anything if you don't have the traccc code turned on. In other words, detray was being masked by the traccc flag, even if the setup of detray was enabled. The underlying bug here is in how ACTS and detray set up vecmem, which was leading to colliding vecmem versions. As I described on the ACTS Mattermost, the simplest ways of mitigating this issue is to set This PR also makes that the default behaviour so that future changes to the detray and traccc build systems won't cause downstream failures. |
This commit fixes an inherited bug from the detray repository in which the use of `vecmem-check-language` does not correctly use the path exported by vecmem. Also turns off the setup of detray by default, in order not to disturb the user experience while we complete the integration.
stephenswat
force-pushed
the
build/detray_fixes
branch
from
d3d9a34 to
6236eff
Compare
stephenswat
changed the title
stephenswat
force-pushed
the
build/detray_fixes
branch
from
1ce1af7 to
6236eff
Compare
|
|
In the LCG stacks it wasn't enough to turn detray OFF, vecmem also had to be OFF not to be found : https://gitlab.cern.ch/sft/stacks/lcgcmake/-/merge_requests/3917. |
The fact that only turning detray off didn't fix the issue is worrying. Do you have logs showing what went wrong with detray turned off but vecmem turned on? |
|
Yes, but they only show that vecmem was not found, for example on Alma9: https://lcgapp-services.cern.ch/cdash/build/172617/file/11834. This is with the first commit of https://gitlab.cern.ch/sft/stacks/lcgcmake/-/merge_requests/3917 (with detray OFF but vecmem not set, so the default value). |
4 participants
This commit fixes an inherited bug from the detray repository in which the use of
vecmem-check-languagedoes not correctly use the path exported by vecmem. Also turns off the setup of detray by default, in order not to disturb the user experience while we complete the integration.--- END COMMIT MESSAGE ---
see discussion https://mattermost.web.cern.ch/acts/pl/jbuxpdkyh3b18y9o48pepmcx3o