Example: broken lesson submission (teaching demo for students)#26
Open
jchen0506 wants to merge 2 commits into
Open
Example: broken lesson submission (teaching demo for students)#26jchen0506 wants to merge 2 commits into
jchen0506 wants to merge 2 commits into
Conversation
Single lesson YAML with several intentional errors (missing required field, list-as-string for authors/platforms/tags, material with no URL, multi-value recommended_platform) to demonstrate how CI validation responds to a bad submission. Surfaced one at a time (fail-fast) as students fix and re-push. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ACT-CMS Lesson Portal — PR check❌ Checks failed. Please fix the items below and push an update to this branch — the check re-runs automatically. Errors (must fix)See |
validate_lesson_data now collects every problem in a lesson and prints each as its own Error: line instead of returning on the first one, so the PR-check comment lists them together. Later checks are guarded against missing/malformed fields; recommended_platform and platform-partial checks are skipped when platforms isn't a valid list to avoid cascading errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
OH NO I"VE DONE SOMEHTNG WRONG I"M SO TIRED I CAN"T EVEN SPELL CORRECTLY> @jchen0506 PLEASE FIX THIS FOR TME |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A deliberately broken lesson (
lessons/example-broken-lesson.yml) kept as a teaching example so students can see how the portal's CI check reacts to a bad submission. Not meant to be merged.What's wrong with it (on purpose)
The file plants several common mistakes. The CI reports one error per run (fail-fast), so students fix one line, push, and watch the next surface — an iterative, realistic workflow:
descriptionmissingauthorsis a string- "Name")platformsis a stringtagsis a stringgithub_url/colab_urlrecommended_platform: "Google Colab, ChemCompute"platformsCompare against
template.yamlfor the correct reference.Expected result
The
PR Lesson Checkshould fail and post a ❌ comment naming the first error (the missingdescription).