test: enforce 10-second default test budget#415
Conversation
- Gate default-suite cases at or above the 10-second budget behind slow-tests and remove obsolete high-dimensional periodic validation from routine runs. - Move allocation hot-path contracts into a Criterion benchmark over calibrated 2D-5D fixtures, leaving allocation_api as wiring smoke coverage. - Document the toroidal validation limits and add the bench-allocations workflow. Closes #256
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughThis PR enforces a 10s per-test budget in nextest profiles, gates multiple slow/high-dimension proptests behind the ChangesAllocation Measurement and Test Taxonomy Overhaul
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage ∅ diff coverage · -0.01% coverage variation
Metric Results Coverage variation ✅ -0.01% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (1498153) 62504 56738 90.77% Head commit (03a646f) 62504 (+0) 56730 (-8) 90.76% (-0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#415) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
- Move 4D triangulation quality properties behind slow-tests so the default suite stays within the 10-second per-test budget. - Document that over-budget triangulation quality variants run through just test-slow. - Refresh the active changelog for the test-bucket updates.
- Move 4D convex-hull, serialization, and insertion-order robustness properties behind slow-tests so default CI and Codecov runs stay within the 10-second per-test budget. - Document that over-budget convex-hull, serialization, and high-dimensional insertion-order variants run through just test-slow.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 90.76% 90.75% -0.02%
==========================================
Files 71 71
Lines 62294 62294
==========================================
- Hits 56542 56534 -8
- Misses 5752 5760 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Move full 4D TDS invariant property tests behind slow-tests with the existing 5D variants. - Gate 4D facet-topology triangulation properties while keeping the high-dimensional smoke coverage in the default suite. - Document that these 4D/5D property families run through just test-slow.
- Move 4D Delaunay, facet, orientation, and simplex property families behind slow-tests when they exceed the default 10-second CI budget. - Gate the 3D toroidal periodic known-limitation validation case with the slow-test suite. - Document the additional 4D/5D slow-test coverage in the test README.
Closes #256