Remove old Boutiques integrator#1609
Merged
Merged
Conversation
The old integrator code is completely removed in this PR.
These changes make the old Boutiques test suite, which was designed for the old integrator, to now apply its tests to the behavior of the new integrator.
This is very kludgy, I adapted the test suite that was developed for the old integrator to perform most of its checks on the code for the new integrator. Given they work differently, I needed to make lot sof small adjustments, sometimes resulting in quite ugly code.
prioux
added
Enhancement
Testing
Refactoring
Priority: Normal
Boutiques
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the old template-based integrator for Boutiques has been completely removed.
The majority of the changes required removing a bunch of the generator files for CbrainTasks and their views (most of them were
BrainPortal/lib/cbrain_task_generators). After that adjustments needed to be made to a bunch of configurations here and there in the codebase.The most changed files are the test suite. I decided to keep the original test suite and adapt it to the new integrator instead, given the new integrator didn't have a test suite. This was very kludgy.
I recommend looking at each commit individually, it's worth seeing the progression.
I found some bugs or limitation in the new integrator, at the same time. These can be seen in the files boutiques_portal_task.rb and boutiques_cluster_task.rb .