Core - Revise server settings framework - #452
Open
Kexanone wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ArmaReforgerScriptedtoACE_SettingsSystem.ACE_SettingsConfiginstance.ACE_ModSettings::Initfor postprocessing settings.Notes:
ACE_ModSettingsand add your settings as attributes there (e.g.ACE_Finger_Settings)ACE_MissionHeaderSettingsto add your settings to the mission header (e.g. Finger's moddedACE_MissionHeaderSettings)Configs/ACE/Settings.confto add your settings to the config (e.g. Finger'sSettings.confoverride)ACE_SettingsConfigviamoddedoverride (For example, see Finger - Replicate settings via config codec #453). Writing codecs manually is a bit annoying, so in future we may want to switch to an attribute "ACE_RplSetting" that can be added to a setting to get it replicated automatically, however this would require runtime reflection to be expanded, e.g. missing setter (see https://feedback.bistudio.com/T174034).ACE_SettingsHelperT