Ordered results: + Document.OrderedResult integration#445
Closed
MartinKavik wants to merge 1 commit intoabsinthe-graphql:masterfrom
Closed
Ordered results: + Document.OrderedResult integration#445MartinKavik wants to merge 1 commit intoabsinthe-graphql:masterfrom
MartinKavik wants to merge 1 commit intoabsinthe-graphql:masterfrom
Conversation
Contributor
|
Hey @MartinKavik I've created a PR on the absinthe_tutorial project that shows how you can accomplish this without any changes to Absinthe at all: absinthe-graphql/absinthe_tutorial#1 As noted in that PR, we may well make a few changes to Absinthe so that folks can avoid copying the whole |
Contributor
|
@benwilson512 Should this be closed? |
bruce
changed the title
Contributor
|
Yea, this isn't the way we want to go about this and it isn't feasible to try to redirect a PR this size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #352
Well, this PR is quite big, but the most changes are new tests for ordered results.
:orderedwhich switches betweenDocument.ResultandDocument.OrderedResultmix testI can provide more info / write comments, etc. if you want. Thanks for review.