Merge branch dev with rel-10.5#25736
Merged
Merged
Conversation
… localeLoaders object
Angular - Enhancing the locale loading mechanism and adding a fallback
voloagent
approved these changes
Jul 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the Angular core package’s locale-loading utilities between dev and rel-10.5, improving ESBuild compatibility for locale imports and adding coverage to prevent regressions.
Changes:
- Refactored ESBuild locale loading to use a shared hard-coded loader map and to consistently go through the locale loader/error-handler path.
- Expanded the supported locale set (e.g.,
ja,ko,th,vi) for both ESBuild loaders and the webpackwebpackIncludefilter. - Added a dedicated unit test suite covering supported locales, unsupported-locale behavior, and stored-locale fallback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| npm/ng-packs/packages/core/src/lib/tests/register-locale.spec.ts | Adds tests for registerLocaleForEsBuild behavior (supported, unsupported, stored fallback). |
| npm/ng-packs/packages/core/locale/src/utils/register-locale.ts | Centralizes ESBuild locale loaders, enforces explicit “supported locale” detection, and expands webpack locale include list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generated automatically to merge dev with rel-10.5. Please review the changed files before merging to prevent any errors that may occur.