feat: add createApnsBroadcast (RSH1d) and liveActivity methods in PushAdmin#500
Open
ttypic wants to merge 1 commit into
Open
feat: add createApnsBroadcast (RSH1d) and liveActivity methods in PushAdmin#500ttypic wants to merge 1 commit into
createApnsBroadcast (RSH1d) and liveActivity methods in PushAdmin#500ttypic wants to merge 1 commit into
Conversation
ttypic
force-pushed
the
AIT-794/live-activity
branch
from
8c99684 to
1ffc3d4
Compare
ttypic
force-pushed
the
AIT-794/live-activity
branch
from
1ffc3d4 to
9dbe6ac
Compare
ttypic
force-pushed
the
AIT-794/live-activity
branch
from
9dbe6ac to
11d263f
Compare
…SH1e1–RSH1e3) in PushAdmin - Include tests for `start`, `update`, and `end` methods with various scenarios and error propagation. - Update related specifications and documentation to reflect test coverage and implementation.
ttypic
force-pushed
the
AIT-794/live-activity
branch
from
11d263f to
abbf440
Compare
paddybyers
requested changes
Jul 3, 2026
paddybyers
left a comment
paddybyers
left a comment
Member
There was a problem hiding this comment.
LGTM but a couple of comments. I think we could be grouping more assertions into a single test
|
|
||
| --- | ||
|
|
||
| ## RSH1d — createApnsBroadcast returns id and apnsChannelId |
Member
There was a problem hiding this comment.
Can we combine several of these tests? They're doing the same thing, just with different assertions
|
|
||
| request = captured_requests[0] | ||
| ASSERT request.method == "POST" | ||
| ASSERT request.url.path == "/push/apnsBroadcastChannels/broadcast-1/start" |
Member
There was a problem hiding this comment.
Do we want this broadcast id to be randomised to prevent test runs from conflicting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start,update, andendmethods with various scenarios and error propagation.