ci: GHA workflow security cleanup#15
Merged
Merged
Conversation
Audit cleanup: pass persist-credentials: false to actions/checkout so the default GITHUB_TOKEN is not left in the local git config after checkout. The workflow does not push or otherwise use the token after checkout.
Audit cleanup: declare top-level permissions: {} so the workflow's
default GITHUB_TOKEN starts with no scopes, and grant the check job
only what it actually needs:
- contents: read for actions/checkout
- checks: write for dorny/test-reporter to publish results
Audit cleanup: pin each uses: reference to a full commit SHA, with the resolved tag preserved in a trailing comment, so an upstream tag move cannot silently change what runs in CI. - actions/checkout v4 -> v4.3.1 - actions/setup-dotnet v3 -> v3.4.2 - dorny/test-reporter v1 -> v1.9.1
ttypic
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine hygiene pass over the GitHub Actions workflow in this repo, addressing findings from a workflow security audit. Changes are split into three commits, one per finding type:
actions/checkoutso the defaultGITHUB_TOKENis not left in the local git config after checkout.permissions: {}, with thecheckjob granted only theGITHUB_TOKENscopes it actually needs (contents: readfor checkout,checks: writefordorny/test-reporter).No behavioural changes intended — the workflow runs the same checks against the same inputs.