Skip to content

Ensure we do not create large graphs during loading #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asl merged 1 commit into from
May 26, 2026
Merged

Ensure we do not create large graphs during loading #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/test/debruijn/contracted_graph_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ TEST(ContractedGraph, Construction) {
EXPECT_TRUE(contracted_graph->ContainsVertex(vertex));
}

const size_t first_id = 132238743;
const size_t second_id = 102357497;
const size_t third_id = 243148631;
const size_t fourth_id = 170924699;
const size_t first_id = 743;
const size_t second_id = 497;
const size_t third_id = 631;
const size_t fourth_id = 699;

std::map<size_t, VertexId> simple_vertex_map;
for (const auto& vertex: vertex_it_helper) {
Expand Down Expand Up @@ -98,7 +98,7 @@ TEST(ContractedGraph, Construction) {
EXPECT_EQ(contracted_graph->GetInDegree(simple_vertex_map.at(first_id)), 0);

contraction_threshold = 25000;
contracted_graph = std::move(CreateContractedGraph(g, contraction_threshold));
contracted_graph = CreateContractedGraph(g, contraction_threshold);
EXPECT_EQ(contracted_graph->size(), 2);
EXPECT_EQ(contracted_graph->CountEdges(), 0);
}
Expand All @@ -112,10 +112,10 @@ TEST(ContractedGraph, Subgraph) {
size_t contraction_threshold = 80;
auto contracted_graph = CreateContractedGraph(g, contraction_threshold);

const size_t first_id = 132238743;
const size_t second_id = 102357497;
const size_t third_id = 243148631;
const size_t fourth_id = 170924699;
const size_t first_id = 743;
const size_t second_id = 497;
const size_t third_id = 631;
const size_t fourth_id = 699;

omnigraph::IterationHelper<Graph, VertexId> vertex_it_helper(g);

Expand Down
20 changes: 10 additions & 10 deletions src/test/debruijn/graph_fragments/contracted_graph/simple_bulge.cvr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
10
419360740 176.768502 .
419360741 176.768502 .
419388514 464.834644 .
419388515 464.834644 .
419433555 528.524995 .
419433556 528.524995 .
419434025 727.076923 .
419434026 727.076923 .
419442075 179.959408 .
419442076 179.959408 .
740 176.768502 .
741 176.768502 .
514 464.834644 .
515 464.834644 .
555 528.524995 .
556 528.524995 .
25 727.076923 .
26 727.076923 .
75 179.959408 .
76 179.959408 .
20 changes: 10 additions & 10 deletions src/test/debruijn/graph_fragments/contracted_graph/simple_bulge.flcvr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
10
419360740 6909 .
419360741 5834 .
419388514 15538 .
419388515 13733 .
419433555 16557 .
419433556 13501 .
419434025 20217 .
419434026 22879 .
419442075 5129 .
419442076 6935 .
740 6909 .
741 5834 .
514 15538 .
515 13733 .
555 16557 .
556 13501 .
25 20217 .
26 22879 .
75 5129 .
76 6935 .
2 changes: 1 addition & 1 deletion src/test/debruijn/graph_fragments/contracted_graph/simple_bulge.gid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
419462720
720
36 changes: 18 additions & 18 deletions src/test/debruijn/graph_fragments/contracted_graph/simple_bulge.grp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
8 10
Vertex 102357496 ~ 102357497 .
Vertex 102357497 ~ 102357496 .
Vertex 132238742 ~ 132238743 .
Vertex 132238743 ~ 132238742 .
Vertex 170924698 ~ 170924699 .
Vertex 170924699 ~ 170924698 .
Vertex 243148630 ~ 243148631 .
Vertex 243148631 ~ 243148630 .
Vertex 496 ~ 497 .
Vertex 497 ~ 496 .
Vertex 742 ~ 743 .
Vertex 743 ~ 742 .
Vertex 698 ~ 699 .
Vertex 699 ~ 698 .
Vertex 630 ~ 631 .
Vertex 631 ~ 630 .

Edge 419360740 : 243148631 -> 170924699, l = 3905 ~ 419360741 .
Edge 419360741 : 170924698 -> 243148630, l = 3905 ~ 419360740 .
Edge 419388514 : 170924698 -> 243148630, l = 3943 ~ 419388515 .
Edge 419388515 : 243148631 -> 170924699, l = 3943 ~ 419388514 .
Edge 419433555 : 132238743 -> 102357497, l = 20284 ~ 419433556 .
Edge 419433556 : 102357496 -> 132238742, l = 20284 ~ 419433555 .
Edge 419434025 : 102357497 -> 243148631, l = 104 ~ 419434026 .
Edge 419434026 : 243148630 -> 102357496, l = 104 ~ 419434025 .
Edge 419442075 : 102357496 -> 132238742, l = 19388 ~ 419442076 .
Edge 419442076 : 132238743 -> 102357497, l = 19388 ~ 419442075 .
Edge 740 : 631 -> 699, l = 3905 ~ 741 .
Edge 741 : 698 -> 630, l = 3905 ~ 740 .
Edge 514 : 698 -> 630, l = 3943 ~ 515 .
Edge 515 : 631 -> 699, l = 3943 ~ 514 .
Edge 555 : 743 -> 497, l = 20284 ~ 556 .
Edge 556 : 496 -> 742, l = 20284 ~ 555 .
Edge 25 : 497 -> 631, l = 104 ~ 26 .
Edge 26 : 630 -> 496, l = 104 ~ 25 .
Edge 75 : 496 -> 742, l = 19388 ~ 76 .
Edge 76 : 743 -> 497, l = 19388 ~ 75 .
20 changes: 10 additions & 10 deletions src/test/debruijn/graph_fragments/contracted_graph/simple_bulge.pos
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
10
419360740 0
419360741 0
419388514 0
419388515 0
419433555 0
419433556 0
419434025 0
419434026 0
419442075 0
419442076 0
740 0
741 0
514 0
515 0
555 0
556 0
25 0
26 0
75 0
76 0
20 changes: 10 additions & 10 deletions src/test/debruijn/graph_fragments/contracted_graph/simple_bulge.sqn
View file
Open in desktop

Large diffs are not rendered by default.

Loading