perf: performance benchmarking with Criterion and dhat#51
Open
AThomas314 wants to merge 3 commits into
Open
Conversation
Owner
|
Hi @AThomas314, Generally, most additions seem to make sense, but I will let you know my exact thoughts in a more detailed review per PR. One small observation already: The filepaths used in the benchmarks could likely benefit from the Cheers, |
Author
|
Hey @aarkue, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a performance benchmarking and profiling suite for the rust4pm library. By integrating Criterion for statistical time-series benchmarking and dhat for heap allocation profiling, this PR establishes the necessary infrastructure to track performance and prevent regressions as we continue to scale the engine.
Changes
How to Run
To execute the benchmarks, run:
cargo bench --features dataframes
Notes
This is the first phase PR, future PRs will include benchmarking of other functions